-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update client deps #22709
Update client deps #22709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good, but there are a number of FF packages in pnpm-lock on version 2.3.0 as well as 2.3.1 (@fluidframework/tree is one such package). Even with pnpm's dep tree structure, seems like that could cause some strange issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! It would be nice to also update the package.json files eventually too, but not critical. Maybe we need to consider some per-release maintenance tasks that we do regularly.
Updating the minimum supported version in our package.json files to remove support for older versions of packages seems like it could be a breaking change for prod deps in some cases, so in general I think we should probably leave them alone. Updating them for dev deps would be ok though. |
@CraigMacomber |
I think this is expected? Our type tests test against the previous minor's .0 release, and those will pull in patched versions of their deps when updating, resulting in this duplication for all packages which have type tests and are also depended on by a package with type tests, and have been patched. If we don't want this behavior, our type tests should probably use ~ versions. |
I went ahead and made the type tests target ~ versions to avoid the duplication since it was easy. If we like that we can update our type test tooling to prefer that format by default when updating their package versions. |
⯆ @fluid-example/bundle-size-tests: -2.5 KB
Baseline commit: 9c58bf3 |
Description
Update client dependencies, holding back socket.io-client to avoid socketio/socket.io#5202.
Makes type tests target ~ version, to avoid duplicating previous package versions:
pnpm exec flub typetests -g client --exact "~2.3.0"
Reviewer Guidance
The review process is outlined on this wiki page.